Skip to content

LWG Poll 3: P2117R0 C++ Standard Library Issues Resolved Directly In Prague #3749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 65 commits into from
Feb 28, 2020
Merged

LWG Poll 3: P2117R0 C++ Standard Library Issues Resolved Directly In Prague #3749

merged 65 commits into from
Feb 28, 2020

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Feb 19, 2020 •
edited by zygoloid
Loading

Notes/issues:

  • This was based on branch motions-2020-02-lwg-2 in order to resolve conflicts which would otherwise arise.
  • LWG3247 not applied; conflicts with wording in LWG3299 (contacted lwgchair)
  • LWG3269 [time.parse]/p3 Fixed wording in list of constraints by adding "has" before "value is".
  • LWG3334 What about function declarations which are still in synopsis [syncstream.osyncstream.overview]?
  • LWG1203 I don't see that the modified operators were ever declared in class basic_istream - why is that? Note also that the referenced text was modified by other issues.
  • LWG3314 Wording in [time.duration.io] conflicts with that of LWG3317; applied anyway.
    ** Edit issue: \impldef may need work; Latex can't handle my attempts at:
\impldef{whether \tcode{\placeholder{units_suffix}} is \tcode{"\textmu{}s"} or \tcode{"us"} when \tcode{Period::type} is \tcode{micro}}
\impldef{whether the unit suffix is \tcode{"\textmu{}s"} or \tcode{"us"} when \tcode{Period::type} is \tcode{micro}}

Fixes #3705.
Fixes cplusplus/nbballot#371.
Fixes cplusplus/nbballot#269.
Fixes cplusplus/nbballot#270.
Fixes cplusplus/nbballot#226.
Fixes cplusplus/nbballot#151.
Fixes cplusplus/nbballot#167.
Fixes cplusplus/nbballot#280 (LWG3281 was superseded by LWG3282).
Fixes cplusplus/nbballot#281.

@jensmaurer jensmaurer changed the title Motions 2020 02 lwg 3 LWG Poll 3: P2117R0 C++ Standard Library Issues Resolved Directly In Prague Feb 19, 2020
@jensmaurer jensmaurer added this to the post-2020-02 milestone Feb 19, 2020
JohelEGP
JohelEGP suggested changes Feb 19, 2020
View reviewed changes
JohelEGP
JohelEGP reviewed Feb 20, 2020
View reviewed changes
jensmaurer
jensmaurer requested changes Feb 21, 2020
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please augment each commit description with a "Also fixes NB US xxx (C++20 CD)." where applicable.

For example, LWG3328 fixes NL 375.
This is recorded in the source paper as "Addresses NL 375".

This is probably a situation where a force-push is desirable, despite these being straw-polls papers.

@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Feb 21, 2020
@jensmaurer
Copy link
Member

LWG 3282 also fixes US 285, but is not marked as such.

@JohelEGP JohelEGP mentioned this pull request Feb 21, 2020
Merged
@burblebee burblebee force-pushed the motions-2020-02-lwg-3 branch from f95425d to 1493b4e Compare February 22, 2020 22:26
@burblebee burblebee removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Feb 22, 2020
@burblebee burblebee requested a review from jensmaurer February 22, 2020 22:30
@zygoloid zygoloid force-pushed the motions-2020-02-lwg-3 branch 2 times, most recently from 9585655 to 24a0b15 Compare February 27, 2020 02:59
Dawn Perchik and others added 17 commits February 27, 2020 13:52
@zygoloid
LWG1203 More useful rvalue stream insertion
ffb23d0 
Merged with P1721R2, which also converted the Remarks: element to a
Constraints: element, but with a more consistent wording pattern.
@zygoloid
LWG2859 Definition of reachable in [ptr.launder] misses pointer arith…
5cb2353 
…metic from pointer-interconvertible object
@zygoloid
LWG3018 shared_ptr of function type
c36fe2d
@zygoloid
LWG3050 Conversion specification problem in chrono::duration constructor
7fb48d1
@zygoloid
LWG3141 CopyConstructible doesn't preserve source values
0433c2b
@zygoloid
LWG3150 UniformRandomBitGenerator should validate min and max
4f8b121
@zygoloid
LWG3175 The CommonReference requirement of concept SwappableWith is n…
f45c8df 
…ot satisfied in the example
@zygoloid
LWG3200 midpoint should not constrain T is complete
43307b1
@zygoloid
LWG3201 lerp should be marked as noexcept
b795649
@zygoloid
LWG3226 zoned_time constructor from string_view should accept zoned_t…
e6237b4 
…ime<Duration2, TimeZonePtr2>

[time.zone.zonedtime.ctor] Inserted "the type" before the non-functions
in the constraints because otherwise the wording
"the return type of f(A) and B" can be parsed in a way that makes no sense.
@zygoloid
LWG3237 LWG 3038 and 3190 have inconsistent PRs
b1ac52a
@zygoloid
LWG3238 Insufficiently-defined behavior of std::function deduction gu…
000771c 
…ides
@zygoloid
LWG3242 std::format: missing rules for arg-id in width and precision
6a5a1e0
@zygoloid
LWG3243 std::format and negative zeroes
894c265
@zygoloid
LWG3247 ranges::iter_move should perform ADL-only lookup of iter_move
852dd05
@zygoloid
LWG3248 std::format #b, #B, #o, #x, and #X presentation types misform…
10bf2e6 
…at negative numbers
@zygoloid
LWG3250 std::format: # (alternate form) for NaN and inf
d13144b
Dawn Perchik added 27 commits February 27, 2020 17:56
@zygoloid
LWG3362 Strike stop_source's operator!=
51f8eb3
@zygoloid
LWG3363 drop_while_view should opt-out of sized_range
3065e49
@zygoloid
LWG3364 Initialize data members of ranges and their iterators
a6c77a7
@zygoloid
LWG3367 Integer-class conversions should not throw
e1322a6 
[iterator.concept.winc] Fix "Expressions" to be singular when refering to "E".
@zygoloid
LWG3369 span's deduction-guide for built-in arrays doesn't work
78cf96a
@zygoloid
LWG3371 visit_format_arg and make_format_args are not hidden friends
b65c9bb
@zygoloid
LWG3372 format_to should not try to deduce Out twice
681890f
@zygoloid
LWG3373 {to,from}_chars_result and format_to_n_result need the "we re…
287caa4 
…ally mean what we say" wording
@zygoloid
LWG3374 P0653 + P1006 should have made the other std::to_address over…
5161ed3 
…load constexpr
@zygoloid
LWG3375 decay in viewable_range should be remove_cvref
de5d45f
@zygoloid
LWG3377 elements_view::iterator befriends a specialization of itself
aedc6e2
@zygoloid
LWG3379 "safe" in several library names is misleading
ee3a10b
@zygoloid
LWG3380 common_type and comparison categories
bb8cc74
@zygoloid
LWG3381 begin and data must agree for contiguous_range
2dad1b6 
[range.refinements] Removed redundant parens and added missing "is true".
@zygoloid
LWG3382 NTTP for pair and array
55f729c
@zygoloid
LWG3383 [time.zone.leap.nonmembers] sys_seconds should be replaced wi…
824d859 
…th seconds
@zygoloid
LWG3384 transform_view::sentinel has an incorrect operator-
2da18b6
@zygoloid
LWG3385 common_iterator is not sufficiently constrained for non-copya…
69d825b 
…ble iterators
@zygoloid
LWG3387 [range.reverse.view] reverse_view<V> unintentionally requires…
96e2bc4 
… irange<const V>
@zygoloid
LWG3388 view iterator types have ill-formed <=> operators
944bb13
@zygoloid
LWG3389 A move-only iterator still does not have a counted_iterator
5c30109
@zygoloid
LWG3390 make_move_iterator() cannot be used to construct a move_itera…
f343f31 
…tor for a move-only iterator
@zygoloid
LWG3393 Missing/incorrect feature test macro for coroutines
859d793
@zygoloid
LWG3395 Definition for three-way comparison needs to be updated (US 152)
b6ef98b 
Also fixes NB US 152 (C++20 CD).
@zygoloid
LWG3396 Clarify point of reference for source_location::current() (DE…
ade9b15 
… 169)

Also fixes NB DE 169 (C++20 CD).
@zygoloid
LWG3397 ranges::basic_istream_view::iterator should not provide itera…
99cce31 
…tor_category
@zygoloid
LWG3398 tuple_element_t is also wrong for const subrange
7f42183
@zygoloid zygoloid force-pushed the motions-2020-02-lwg-3 branch from 28fe6c3 to 7f42183 Compare February 28, 2020 01:56
@zygoloid zygoloid merged commit 1f642ba into master Feb 28, 2020
@jensmaurer jensmaurer deleted the motions-2020-02-lwg-3 branch February 12, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensmaurer jensmaurer Awaiting requested review from jensmaurer

1 more reviewer

@JohelEGP JohelEGP JohelEGP requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2020-02
Development

Successfully merging this pull request may close these issues.

GB274 24.02 Add range_size_t LWG 3335 US273 24.02 Rename all_view LWG 3335 GB229 20.20.03 Allow std::format to throw for argument / format string mismatch LWG 3340 DE169 17.08.2 p3 Clarify point of reference for source_location::current() LWG 3396 US152 16.03.4 [defns.comparison] Update definition for three-way comparison LWG 3395
US284 24.05.3 Prevent conversion from pair-like types to subranges LWG 3282 US285 24.05.3 p1 Prevent derived-to-base slicing with subrange constructors LWG 3282 NL375 D.19 [depr.fs.path.factory] Clarify that std::string is not good for UTF-8 LWG 3328 [2020-02 LWG Poll 3] P2117R0 C++ Standard Library Issues Resolved Directly In Prague
4 participants
@burblebee @jensmaurer @JohelEGP @zygoloid